Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared types refactor #417

Merged
merged 3 commits into from
May 15, 2020
Merged

Shared types refactor #417

merged 3 commits into from
May 15, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented May 14, 2020

Summary of changes
Changes introduced in this pull request:

  • Moving shared types to own crate (was overloading the vm crate with things that shouldn't be for convenience)
    • If this crate gets bulky in the future we can just seperate by feature, but without it the crates won't be very composable and will cause a lot of issues
    • Moved gas tracker to interpreter crate (was placed in vm crate because it was shared, but now that all the components using it are in the same crate I moved there)
      (Issue arose from message crate having to pull in all proofs lib because of the conversions)

This refactor was pretty annoying, so hopefully we can agree on this (or something similar) so we don't have to revisit

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit b7f6f92 into master May 15, 2020
@austinabell austinabell deleted the austin/types/ref branch May 15, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants