Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-host proof parameters #4170

Merged
merged 1 commit into from
Apr 10, 2024
Merged

self-host proof parameters #4170

merged 1 commit into from
Apr 10, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Apr 9, 2024

Summary of changes

Changes introduced in this pull request:

  • by default, use self-hosted proof parameters. In case of errors (or if forced by an environmental variable), fall back to the IPFS gateway. This should resolve numerous issues with the slow download and knocking out our GH jobs.

Even in good conditions, it's faster:

❯ export FOREST_PROOFS_ONLY_IPFS_GATEWAY=1
❯ time forest-tool fetch-params --keys
________________________________________________________
Executed in   11.83 secs      fish           external
   usr time  620.09 millis    0.00 micros  620.09 millis
   sys time  338.11 millis  276.00 micros  337.83 millis
❯ export FOREST_PROOFS_ONLY_IPFS_GATEWAY=0
❯ time forest-tool fetch-params --keys
________________________________________________________
Executed in    4.59 secs      fish           external
   usr time  399.09 millis  217.00 micros  398.87 millis
   sys time  244.08 millis   48.00 micros  244.03 millis

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the cs-hosted-proofs branch 3 times, most recently from 83c78dd to c4a61d6 Compare April 9, 2024 16:18
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review April 9, 2024 16:20
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner April 9, 2024 16:20
@LesnyRumcajs LesnyRumcajs requested review from elmattic and aatifsyed and removed request for a team April 9, 2024 16:20
Copy link
Contributor

@aatifsyed aatifsyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR description should also live in the module documentation

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 10, 2024
@LesnyRumcajs
Copy link
Member Author

Your PR description should also live in the module documentation

This module has no documentation - it's just a set of loosely coupled functions. I'll address it in a follow-up.

Merged via the queue into main with commit 84d9105 Apr 10, 2024
30 checks passed
@LesnyRumcajs LesnyRumcajs deleted the cs-hosted-proofs branch April 10, 2024 09:52
This was referenced Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants