Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefix Forest-specific methods #4215

Merged
merged 2 commits into from
Apr 16, 2024
Merged

prefix Forest-specific methods #4215

merged 2 commits into from
Apr 16, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Apr 16, 2024 •
edited

Summary of changes

Changes introduced in this pull request:

  • @ansermino noticed that some of the methods we have don't exist in Lotus. Our main focus now is on parity between Forest and Lotus, so for now let's just hide our internal methods behind an internal Forest prefix.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review April 16, 2024 09:11
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner April 16, 2024 09:11
@LesnyRumcajs LesnyRumcajs requested review from ruseinov and aatifsyed and removed request for a team April 16, 2024 09:11
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit e807e5b Apr 16, 2024
27 checks passed
@LesnyRumcajs LesnyRumcajs deleted the rename-forest-specific-rpcs branch April 16, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@aatifsyed aatifsyed aatifsyed approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LesnyRumcajs @lemmih @aatifsyed