Add default implementations for Store bulk operations #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvermeulen
requested review from
ec2,
RajarupanSampanthan,
austinabell,
flodesi,
StaticallyTypedAnxiety and
dutterbutter
timvermeulen
force-pushed
the
tim/store-bulk-operations
branch
from
97ec54c
to
e02f795
Compare
austinabell
approved these changes
May 18, 2020
ec2
approved these changes
May 19, 2020
timvermeulen
force-pushed
the
tim/store-bulk-operations
branch
from
e02f795
to
665f368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Store's bulk operations that repeatedly call the corresponding non-bulk operationRocksDb::bulk_writeis unaffected because it improves over the default implementation)