-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix balance comparison to zero test #4240
Conversation
i=$((i+1)) | ||
|
||
: "Checking balance $i/20" | ||
sleep 30s | ||
ADDR_TWO_BALANCE=$($FOREST_WALLET_PATH balance "$ADDR_TWO") | ||
ADDR_TWO_BALANCE=$($FOREST_WALLET_PATH balance "$ADDR_TWO" -e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use long flag unless it obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
/// Output is rounded to 4 significant figures by default. | ||
/// Do not round | ||
// ENHANCE(aatifsyed): add a --round/--no-round argument pair | ||
#[arg(long, alias = "exact-balance", short_alias = 'e')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd omit short flags unless it's very obvious, e.g., -i
for interactive or -f
to force.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
Summary of changes
Changes introduced in this pull request:
forest-wallet balance
asforest-wallet list
Example:
By design, an empty wallet will always print
0 FIL
.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist