[Feature] Filecoin.SyncSubmitBlock RPC. #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruseinov
requested review from
lemmih and
sudo-shashank
and removed request for
a team
aatifsyed
approved these changes
Apr 19, 2024
src/rpc/methods/sync.rs
Outdated
Comment on lines
22
to
23
| use crate::blocks::GossipBlock; | ||
| use crate::libp2p::{IdentTopic, NetworkMessage, PUBSUB_BLOCK_STR}; |
There was a problem hiding this comment.
nit: with the rest of the imports
There was a problem hiding this comment.
Ah, I can see now! not clear without seeing the full diff.
aatifsyed
approved these changes
Apr 19, 2024
hanabi1224
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Filecoin.SyncSubmitBlockRPC endpoint.Reference issue to close (if applicable)
Work on #4245
Other information and links
Needed for miner. There needs to be a follow-up that introduces all the sanity checks, the description can be found in the referenced issue.
Change checklist