Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configurable timeout to rpc client #4253

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Apr 22, 2024

Summary of changes

Changes introduced in this pull request:

  • added environment variable FOREST_RPC_DEFAULT_TIMEOUT to configure the default RPC timeout. This is useful for testing the endpoints on a lower-end machine (like GH workers, which timeout from time to time).
  • Increased the default timeout for the api compare tests to 120.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review April 22, 2024 10:46
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner April 22, 2024 10:46
@LesnyRumcajs LesnyRumcajs requested review from lemmih and sudo-shashank and removed request for a team April 22, 2024 10:46
@elmattic elmattic added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2024
@hanabi1224 hanabi1224 added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit aee172e Apr 23, 2024
30 checks passed
@hanabi1224 hanabi1224 deleted the configurable-rpc-timeout branch April 23, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants