Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Filecoin.MinerCreateBlock #4255

Merged
merged 3 commits into from
May 7, 2024
Merged

impl Filecoin.MinerCreateBlock #4255

merged 3 commits into from
May 7, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Apr 22, 2024

Summary of changes

Changes introduced in this pull request:

  • implemented Filecoin.MinerCreateBlock,
  • changed wallet import so that it allows specifying the key via stdin non-interactively,
  • both Lotus and Forest now share the same wallet key,
  • first write tests - as a follow-up I'll uncomment ones that were blocked by this.

Reference issue to close (if applicable)

Closes #4202

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the rpc-miner-create-block branch 8 times, most recently from e23aa55 to 4e4e784 Compare April 25, 2024 18:22
@LesnyRumcajs LesnyRumcajs force-pushed the rpc-miner-create-block branch 3 times, most recently from 1211298 to 4476371 Compare May 6, 2024 16:19
@LesnyRumcajs LesnyRumcajs force-pushed the rpc-miner-create-block branch 2 times, most recently from 42ebc5f to 4f0fbc8 Compare May 6, 2024 16:27
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review May 6, 2024 16:52
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner May 6, 2024 16:52
@LesnyRumcajs LesnyRumcajs requested review from elmattic and aatifsyed and removed request for a team May 6, 2024 16:52
src/rpc_client/miner_ops.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@aatifsyed aatifsyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see the Miner methods in state.rs moved while you're at it :)

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue May 7, 2024
@LesnyRumcajs
Copy link
Member Author

I'd love to see the Miner methods in state.rs moved while you're at it :)

Sure, I'll do it in a follow-up tomorrow.

Merged via the queue into main with commit 4d86953 May 7, 2024
28 checks passed
@LesnyRumcajs LesnyRumcajs deleted the rpc-miner-create-block branch May 7, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MinerCreateBlock
3 participants