Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double base64 decoding in Filecoin.WalletSign #4297

Merged
merged 1 commit into from
May 8, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented May 8, 2024

Summary of changes

Changes introduced in this pull request:

  • exposed worker address as part of the api-compare,
  • fixed Filecoin.WalletSign endpoint and introduce a conformance test

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review May 8, 2024 13:32
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner May 8, 2024 13:32
@LesnyRumcajs LesnyRumcajs requested review from ruseinov and hanabi1224 and removed request for a team May 8, 2024 13:32
@LesnyRumcajs LesnyRumcajs changed the title fix: double base64 decoding in WalletSign fix: double base64 decoding in Filecoin.WalletSign May 8, 2024
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit b708e2f May 8, 2024
31 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-wallet-sign branch May 8, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants