Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prefix bytes encoding to include mh len #431

Merged
merged 2 commits into from
May 20, 2020
Merged

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • I actually have the worst memory, Cid Prefix to bytes #428 was misleading because it did exist and I had just removed the mh_len during the multihash refactor because it was redundant (at the time) so I added it back
    • Also figured I'd move prefix to own file because that file isn't setup the best (not going to do an actual refactor because hopefully we move to shared rust cid crate in future)

I assume the length is needed for variable length identity hashes, which is why it's included in the prefix bytes.

Reference issue to close (if applicable)

Closes #428

Other information and links

@austinabell austinabell merged commit 033bade into master May 20, 2020
@austinabell austinabell deleted the austin/prefixupd branch May 20, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cid Prefix to bytes
3 participants