Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl Filecoin.StateGetNetworkParams #4315

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented May 13, 2024

Summary of changes

Changes introduced in this pull request:

  • implemented Filecoin.StateGetNetworkParams,
  • added missing network information so that all the data is available for that endpoint, for all supported networks,
  • temporary workaround for bad Lotus behaviour until a new release, see filecoin-project/lotus@7e005be, though we'd also need to update our proof definitions for networks so that synthetic PoRep variants are included.

Reference issue to close (if applicable)

Closes #4299

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the state-get-network-params branch 3 times, most recently from 0ae9fc2 to 3e80a8c Compare May 13, 2024 10:22
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review May 13, 2024 10:57
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner May 13, 2024 10:57
@LesnyRumcajs LesnyRumcajs requested review from lemmih, aatifsyed, a team and sudo-shashank and removed request for a team and aatifsyed May 13, 2024 10:57
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@hanabi1224 hanabi1224 added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 80a103e May 13, 2024
47 checks passed
@hanabi1224 hanabi1224 deleted the state-get-network-params branch May 13, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement StateGetNetworkParams RPC method
4 participants