Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaden/chainstore refactor #432

Merged
merged 6 commits into from
May 20, 2020
Merged

Jaden/chainstore refactor #432

merged 6 commits into from
May 20, 2020

Conversation

flodesi
Copy link
Contributor

@flodesi flodesi commented May 20, 2020

Summary of changes
Changes introduced in this pull request:

  • Convert methods in ChainStore that depend only on DB to functions that take DB as a parameter and not self.
  • General refactoring to functions that relied on the methods described above.

Closes
#430

@flodesi flodesi requested a review from austinabell May 20, 2020 17:04
@flodesi flodesi requested a review from austinabell May 20, 2020 18:19
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have to make a bunch of these functions public later. But we can make them public as we need.

@flodesi flodesi merged commit b1903ba into master May 20, 2020
@flodesi flodesi deleted the jaden/chainstore-refactor branch May 20, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants