Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add expected_network_height metric #4326

Merged
merged 1 commit into from
May 15, 2024
Merged

feat: add expected_network_height metric #4326

merged 1 commit into from
May 15, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented May 15, 2024 •
edited

Summary of changes

Changes introduced in this pull request:

  • added expected_network_height metric

Reference issue to close (if applicable)

Closes #4322

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the expected-network-height-metric branch from a4c1580 to 014309d Compare May 15, 2024 08:49
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review May 15, 2024 08:50
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner May 15, 2024 08:50
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a team May 15, 2024 08:50
hanabi1224
hanabi1224 reviewed May 15, 2024
View reviewed changes
src/networks/metrics.rs Outdated Show resolved Hide resolved
hanabi1224
hanabi1224 reviewed May 15, 2024
View reviewed changes
src/networks/metrics.rs Outdated Show resolved Hide resolved
@LesnyRumcajs LesnyRumcajs marked this pull request as draft May 15, 2024 10:50
@LesnyRumcajs LesnyRumcajs force-pushed the expected-network-height-metric branch from 014309d to c0e3950 Compare May 15, 2024 13:15
@LesnyRumcajs LesnyRumcajs force-pushed the expected-network-height-metric branch from c0e3950 to 2bed130 Compare May 15, 2024 13:26
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review May 15, 2024 13:34
lemmih
lemmih approved these changes May 15, 2024
View reviewed changes
src/networks/mod.rs
// expectedHeight := int64(sinceGenesis.Seconds()) / int64(build.BlockDelaySecs)
// ```
// See <https://github.com/filecoin-project/lotus/blob/b27c861485695d3f5bb92bcb281abc95f4d90fb6/chain/sync.go#L180>
pub fn calculate_expected_epoch(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm partial to leaving out calculate_ from function names. But I'm fine either way.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 0c74df9 May 15, 2024
36 of 47 checks passed
@LesnyRumcajs LesnyRumcajs deleted the expected-network-height-metric branch May 15, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: expected_network_height metric
3 participants
@LesnyRumcajs @lemmih @hanabi1224