fix: set tipset sample size to 1

[lemmih]

Summary of changes

Changes introduced in this pull request:

• Forest would sample tipset HEADs from 5 peers before fully joining a network. This obviously doesn't work if there are fewer than 5 peers available. This PR temporarily sets the sample size to 1. The chain muxer is scheduled to be completely re-written soon.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation,
• I have added tests that prove my fix is effective or that my feature works (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

[LesnyRumcajs]

Does it make the node more likely to follow a bad fork or what are the downsides? Perhaps we could hide parameterize it with environmental variable to unblock miner integration but keep the 5 peers requirement?

[lemmih]

Does it make the node more likely to follow a bad fork or what are the downsides? Perhaps we could hide parameterize it with environmental variable to unblock miner integration but keep the 5 peers requirement?

It makes it more likely that we will follow a fork rather than a more common branch, but we should still eventually end up following the heaviest tipset.

IMO, it isn't worth making it configurable. This entire chain_muxer code is incredibly fragile, and it's being replaced as soon as possible. The new state machine will not have anything similar to the tipset sample parameter.

[LesnyRumcajs]

🙏

[ruseinov]

IMO, it isn't worth making it configurable. This entire chain_muxer code is incredibly fragile, and it's being replaced as soon as possible. The new state machine will not have anything similar to the tipset sample parameter.

Is there a WIP branch with the state machine? :) Looking forward to this new bit of code, chain_muxer is quite hard to follow.