Update serialization vectors #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
added
Maintenance
Status: Needs Review
encoding
austinabell
assigned timvermeulen, RajarupanSampanthan, flodesi and StaticallyTypedAnxiety and unassigned timvermeulen, RajarupanSampanthan, flodesi and StaticallyTypedAnxiety
austinabell
requested review from
StaticallyTypedAnxiety,
flodesi,
RajarupanSampanthan and
timvermeulen
timvermeulen
approved these changes
May 21, 2020
dutterbutter
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
I also refactored the json decoding of UnsignedMessage so it can easily be moved into an actual implementation when that will be needed (or just for reuse with signed message vectors). I did this also so it's easy enough for someone to do the same for BlockHeader (for tests or otherwise as well). I assume at least for debugging, it'll be nice to have the json impls.
Reference issue to close (if applicable)
Closes
Other information and links