Setup GraphSync network interface #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
StaticallyTypedAnxiety,
flodesi,
RajarupanSampanthan and
timvermeulen
dutterbutter
approved these changes
May 26, 2020
Comment on lines
51
to
57
| // self.events | ||
| // .push_back(NetworkBehaviourAction::NotifyHandler { | ||
| // peer_id, | ||
| // // TODO once request manager logic built out | ||
| // event: todo!(), | ||
| // handler: NotifyHandler::Any, | ||
| // }); |
There was a problem hiding this comment.
Maybe remove for now?
There was a problem hiding this comment.
yeah was just leaving for convenience, I'll remove for now tho
ec2
approved these changes
May 26, 2020
timvermeulen
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Just opening as draft for now for transparency and any comments or reviews are welcome :)
I'm planning on finishing the codec impls (should be easy since logic done already in previous) and ensuring all todos added shouldn't be resolved now, then I will open this PR and open any sub issues
Reference issue to close (if applicable)
Closes #382
Other information and links