Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement msg pool #449

Merged
merged 47 commits into from
Jul 8, 2020
Merged

implement msg pool #449

merged 47 commits into from
Jul 8, 2020

Conversation

flodesi
Copy link
Contributor

@flodesi flodesi commented May 26, 2020

Summary of changes
Changes introduced in this pull request:

  • Implementing message pool closely following Lotus' implementation
  • Refactoring already existing code to accommodate message pool

Reference issue to close (if applicable)
Closes #121

flodesi added 22 commits May 26, 2020 10:04
@flodesi
Merge branch 'master' into jaden/implement-msg-pool
3f12a6d
@flodesi
updated mpool cargo.toml
9303053
@flodesi
fixed dependency and some clippy
1b1d3ed
@flodesi
added license
5d6f622
@flodesi
added add to msgpool
bba60ea
@flodesi
finished add and reverted state_manager back to normal
30ea670
@flodesi
Merge branch 'master' into jaden/implement-msg-pool
13c321d
@flodesi
commenting and fmt
2822083
@flodesi
added some unimplemented functions
c01e669
@flodesi
fmt, clippy and documentation
d738418
@flodesi
fix merge conflict
278d80d
@flodesi
Merge branch 'master' into jaden/implement-msg-pool
9ff011d
@flodesi
Merge branch 'master' into jaden/implement-msg-pool
652c19e
@flodesi
Merge branch 'master' into jaden/implement-msg-pool
48f24d4
@flodesi
Merge branch 'master' into jaden/implement-msg-pool
2020516
@flodesi
added prelim msgpool test
85e1aae
@flodesi
fixed merge conflict
48055cc
@flodesi
first test
7d693a8
@flodesi
finished tests
202f86b
@flodesi
fmt and clippy
dffff0b
@flodesi
Merge branch 'master' into jaden/implement-msg-pool
1e34c96
@flodesi
Merge branch 'master' into jaden/implement-msg-pool
1ca5b38
@flodesi flodesi marked this pull request as ready for review June 19, 2020 23:26
@flodesi flodesi requested a review from ec2 July 1, 2020 23:10
dutterbutter
dutterbutter approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@dutterbutter dutterbutter left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work on this.

blockchain/message_pool/src/msgpool.rs Show resolved Hide resolved
austinabell
austinabell suggested changes Jul 4, 2020
View reviewed changes
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
austinabell
austinabell reviewed Jul 6, 2020
View reviewed changes
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
austinabell
austinabell reviewed Jul 7, 2020
View reviewed changes
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Outdated Show resolved Hide resolved
blockchain/message_pool/src/msgpool.rs Show resolved Hide resolved
@flodesi flodesi dismissed ec2’s stale review July 8, 2020 02:21

all changes made

@flodesi flodesi merged commit c7e94f2 into main Jul 8, 2020
@flodesi flodesi deleted the jaden/implement-msg-pool branch July 8, 2020 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

@ec2 ec2 Awaiting requested review from ec2

Assignees
No one assigned
Labels
Blockchain Priority: 2 - High Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Message Pool
5 participants
@flodesi @ec2 @austinabell @StaticallyTypedAnxiety @dutterbutter