Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Filecoin.StateGetAllClaims and Filecoin.StateGetAllAllocations RPC. #4545

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

ruseinov
Copy link
Contributor

@ruseinov ruseinov commented Jul 17, 2024

Summary of changes

Changes introduced in this pull request:

  • Introduces Filecoin.StateGetAllClaims RPC endpoint.
  • Introduces Filecoin.StateGetAllAllocations RPC endpoint.

Reference issue to close (if applicable)

Closes #4500
Closes #4501

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@ruseinov ruseinov marked this pull request as ready for review July 17, 2024 11:06
@ruseinov ruseinov requested a review from a team as a code owner July 17, 2024 11:06
@ruseinov ruseinov requested review from lemmih and LesnyRumcajs and removed request for a team July 17, 2024 11:07
@lemmih
Copy link
Contributor

lemmih commented Jul 17, 2024

No checkmark, no review.

Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could make it less repetitious.

@ruseinov
Copy link
Contributor Author

I wish we could make it less repetitious.

#metoo


for actor_id in actors {
claims.for_each_in(actor_id, |k, v| {
let claim_id = fil_actors_shared::v13::parse_uint_key(k)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is v14 using v13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! copy-paste..

@ruseinov ruseinov added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit aea54e7 Jul 17, 2024
28 checks passed
@ruseinov ruseinov deleted the ru/feature/rpc-get-all-claims branch July 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateGetAllAllocations StateGetAllClaims
4 participants