Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update power, reward and market actors, rt and registered proofs relative to miner actor #458

Merged
merged 15 commits into from
Jun 2, 2020

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented May 28, 2020

Summary of changes
Changes introduced in this pull request:

Important to note, I only updated the parts of the actors that are used within the miner actor. There are still updates to be made to both reward and market actors. I will make a separate issue for each.

  • Updates the power actor and removes unused methods, however, a lot of that logic has just been moved to the miner actor
  • Updates reward actor
  • Updates market actor
  • Adds an additional function to runtime trait and updated delete_actor to include address param
  • Updates registered proofs

Reference issue to close (if applicable)

Closes #455

Other information and links

@dutterbutter dutterbutter changed the title update power, reward and market actors relative to miner actor update power, reward and market actors, rt and registered proofs relative to miner actor May 28, 2020
@dutterbutter dutterbutter added the Spec Change Updates to implementation required due to a Filecoin spec change after implementation label May 28, 2020
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooo that was tedious to verify, great job on the changes though !

blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
types/src/sector/mod.rs Show resolved Hide resolved
types/src/sector/registered_proof.rs Outdated Show resolved Hide resolved
types/src/sector/seal.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/miner/state.rs Show resolved Hide resolved
vm/actor/src/builtin/power/state.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/power/state.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/power/types.rs Show resolved Hide resolved
vm/actor/src/builtin/power/types.rs Show resolved Hide resolved
vm/actor/src/builtin/reward/mod.rs Outdated Show resolved Hide resolved
@austinabell
Copy link
Contributor

This is sufficient to close #455 ya?

Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to get someone else to verify against spec -- a lot of changes so possible I missed something

Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was the hardest thing ive had to look at...

vm/actor/src/builtin/power/policy.rs Outdated Show resolved Hide resolved
@dutterbutter dutterbutter merged commit 206ec56 into master Jun 2, 2020
@dutterbutter dutterbutter deleted the dustin/actor-update branch June 2, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec Change Updates to implementation required due to a Filecoin spec change after implementation Status: Needs Review VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two different StoragePower types
3 participants