Tide JSONRPC over HTTP #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
flodesi,
StaticallyTypedAnxiety,
RajarupanSampanthan and
timvermeulen
austinabell
suggested changes
May 29, 2020
austinabell
reviewed
May 29, 2020
austinabell
reviewed
Jun 3, 2020
austinabell
approved these changes
Jun 3, 2020
StaticallyTypedAnxiety
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
This PR doesn't cover all the ChainAPI methods. Only a few of them. There are some blockers w.r.t. serialization we havent implemented yet.
We are also waiting on Websocket integration for Tide. This should could soon. Then we can implement methods like ChainNotify.