Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements Storage Miner critical Chain API methods #478

Merged
merged 36 commits into from
Jun 8, 2020
Merged

Implements Storage Miner critical Chain API methods #478

merged 36 commits into from
Jun 8, 2020

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Jun 4, 2020

Summary of changes
Changes introduced in this pull request:

  • Implements Storage Miner critical Chain API methods + some other ones.
  • This does not include ChainNotify which will be done later when we've established we have decided on which websocket library to use.

Reference issue to close (if applicable)

Closes #477

Other information and links

ec2 and others added 30 commits May 18, 2020 23:25
@ec2
add tide
432b62c
@ec2
add tide
af03fe1
@ec2
Merge branch 'master' into ec2/rpc/tide
d08275e
@ec2
Merge branch 'master' into ec2/rpc/tide
d84c3cc
@ec2
basic rpc
ea2640d
@ec2
Merge branch 'master' into ec2/rpc/tide
e89c2e0
@ec2
break off to chain_api
95b19b6
@ec2
Merge branch 'master' into ec2/rpc/tide
c30777d
@ec2
Merge branch 'master' into ec2/rpc/tide
f433fec
@ec2
some methods
0a699e8
@ec2
Merge branch 'master' into ec2/rpc/tide
10063c5
@ec2
add a comment
f9c8997
@ec2
Merge branch 'master' into ec2/rpc/tide
d090fca
@ec2
fix some suggestions
c314945
@ec2
more suggestions
1dc7844
@ec2
works now???
c20a10a
@ec2
lint
13cb98d
@ec2
Merge branch 'master' into ec2/rpc/tide
c413002
@ec2
Merge branch 'master' into ec2/rpc/tide
57556d1
@ec2
use new json serialization
a81e0ab
@ec2
bump tide version
6d7cb6d
@ec2
chain_get_tipset_by_height
c4bdcaf
@ec2
Merge branch 'master' into ec2/rpc/tide
eed84b4
@ec2
fix what got broke when merge
fa3f4f7
@ec2
Merge branch 'ec2/rpc/tide' into ec2/rpc/chain
06bb9a3
@ec2
chain_get_genesis
c9a9334
@ec2
a few methods
79d00e5
@ec2
Merge branch 'master' into ec2/rpc/chain
97d68f3
@ec2
get_randomness
7226ebd
@ec2
got them all
b123389
austinabell
austinabell reviewed Jun 8, 2020
View reviewed changes
node/rpc/src/chain_api.rs Outdated Show resolved Hide resolved
node/rpc/src/chain_api.rs Outdated Show resolved Hide resolved
node/rpc/src/chain_api.rs Outdated Show resolved Hide resolved
node/rpc/src/chain_api.rs Outdated Show resolved Hide resolved
node/rpc/src/chain_api.rs Outdated Show resolved Hide resolved
blockchain/blocks/src/header/json.rs Outdated Show resolved Hide resolved
dutterbutter
dutterbutter approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to see comments on the now public methods in chain store. Otherwise LGTM!

@ec2 ec2 merged commit 33310f5 into master Jun 8, 2020
@ec2 ec2 deleted the ec2/rpc/chain branch June 8, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@flodesi flodesi Awaiting requested review from flodesi

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
RPC Status: Merge Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finish off required Chain RPC methods critical to storage mining
3 participants
@ec2 @austinabell @dutterbutter