Update Reward actor to new spec #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
RajarupanSampanthan,
timvermeulen,
StaticallyTypedAnxiety and
flodesi
austinabell
added
Spec Change
ec2
reviewed
Jun 8, 2020
ec2
approved these changes
Jun 8, 2020
dutterbutter
reviewed
Jun 8, 2020
| self.reward_map = rewards.root()?; | ||
| self.reward_total -= &withdrawable_sum; | ||
| Ok(withdrawable_sum) | ||
| pub(super) fn get_effective_network_time( |
There was a problem hiding this comment.
I don't think it matters but get_effective_network_time looks to exist in the actor implementation rather than the state.
There was a problem hiding this comment.
it does, but I chose not to follow here, as it's much cleaner this way
There was a problem hiding this comment.
made 0 sense to me why they had it the way they did
dutterbutter
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #459
Other information and links