Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch seal verification implementation #483

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Parallelized seal verification using Rayon
    • Can't do with a hashmap input (to match go interface 1:1) but looking at the usage it seems better to do as a vector anyway, which can just be referenced to pass into this.
    • Not really much option to have a more generic interface, because it depends on the IntoParallelRefIterator trait, and that forces a specific implementation (which will then be incompatible with MockRuntime needs)

Seems like the best solution than managing threads in an async context, but very open to suggestions on how this can be parallelized better

Reference issue to close (if applicable)

Closes #457

Other information and links

@austinabell austinabell merged commit 21b3b49 into master Jun 8, 2020
@austinabell austinabell deleted the austin/batchseal branch June 8, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement BatchVerifySeals Syscall
3 participants