miner actor implemented #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
timvermeulen,
StaticallyTypedAnxiety,
flodesi and
RajarupanSampanthan
|
I lied about doing all in one commit, figured it might be easier to reverse review if not all at once and I don't want to lose changes and redo any of this: 80e1bd7 I will continue along and do the other ~1/2 tomorrow and can merge the two commits if it makes it easier |
|
p2 6d97b3d |
austinabell
reviewed
Jun 9, 2020
austinabell
approved these changes
Jun 9, 2020
ec2
requested changes
Jun 11, 2020
|
|
||
| impl DeadlineInfo { | ||
| pub fn new(period_start: ChainEpoch, deadline_idx: usize, current_epoch: ChainEpoch) -> Self { | ||
| if deadline_idx < WPOST_PERIOD_DEADLINES { |
There was a problem hiding this comment.
Do you think it is worth checking the above restrictions like period_start > current_epoch here and throwing an Err?
There was a problem hiding this comment.
can't do that, would be inconsistent (unless I'm missing something)
ec2
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #265
Other information and links