Ashanti/winning posts #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaticallyTypedAnxiety
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
austinabell
suggested changes
Jun 12, 2020
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
|
you accidentally committed a file in 821f33b |
austinabell
approved these changes
Jun 15, 2020
ec2
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
LGTM. One thing I would change is having the utils functions take a DB instead of the whole state manager. Looks like (if im correct) that it only relies on the DB from the state manager.... This in turn allows verify_winning_post_proof to also not have to take in self, and just DB. This can be done later on if needed though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #471
Other information and links