Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ecrecover and verify methods #500

Merged
merged 7 commits into from
Jun 16, 2020
Merged

Fix ecrecover and verify methods #500

merged 7 commits into from
Jun 16, 2020

Conversation

flodesi
Copy link
Contributor

@flodesi flodesi commented Jun 15, 2020

Summary of changes
Changes introduced in this pull request:

  • Fix ecrecover method to properly return the required address
  • Update wallet signing for secp256 to return the proper signature including required recovery byte
  • Move bls_verify method to wallet to take advantage of wallet signing
  • Add secp_verify test to test secp verification as well

Reference issue to close (if applicable)

Closes
#498

ec2
ec2 requested changes Jun 16, 2020
View reviewed changes
crypto/src/signature.rs Show resolved Hide resolved
austinabell
austinabell reviewed Jun 16, 2020
View reviewed changes
key_management/src/wallet.rs Outdated Show resolved Hide resolved
key_management/src/wallet_helpers.rs Outdated Show resolved Hide resolved
@flodesi flodesi requested review from ec2 and austinabell June 16, 2020 14:36
austinabell
austinabell reviewed Jun 16, 2020
View reviewed changes
key_management/src/wallet.rs Outdated Show resolved Hide resolved
key_management/src/wallet.rs Outdated Show resolved Hide resolved
@flodesi flodesi requested a review from austinabell June 16, 2020 15:03
@flodesi flodesi merged commit dd396b9 into master Jun 16, 2020
@flodesi flodesi deleted the jaden/ecrecover branch June 16, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@austinabell austinabell austinabell approved these changes

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

@ansermino ansermino Awaiting requested review from ansermino

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
Bug Crypto Priority: 3 - Medium Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flodesi @ec2 @austinabell