Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bare-bones GraphSync ResponseManager #511

Merged
merged 4 commits into from
Jun 23, 2020

Conversation

timvermeulen
Copy link
Contributor

Summary of changes

Adds a very bare-bones ResponseManager that manages PeerResponseSenders and responds to graphsync requests.

Basically a proof of concept because this setup doesn't allow interrupting graphsync requests, which is essential.

Copy link
Contributor

@flodesi flodesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Noticed the clippy failure has an issue created here. Will hold off on approving until that gets fixed

@austinabell
Copy link
Contributor

Looks good. Noticed the clippy failure has an issue created here. Will hold off on approving until that gets fixed

Should be good now once branch is updated

Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah looks fine, can just refactor and finish TODOs when we revisit

@timvermeulen timvermeulen merged commit 4422cdd into master Jun 23, 2020
@timvermeulen timvermeulen deleted the tim/graphsync/response-manager branch June 23, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants