Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet rpc #512

Merged
merged 24 commits into from
Jul 17, 2020
Merged

wallet rpc #512

merged 24 commits into from
Jul 17, 2020

Conversation

flodesi
Copy link
Contributor

@flodesi flodesi commented Jun 22, 2020

Summary of changes
Changes introduced in this pull request:

  • Implement wallet rpc
  • Create 2 new methods in StateManager (get_balance and get_heaviest_balance)
  • Created a method in signed_message.rs to create a new signed message from fields

Reference issue to close (if applicable)

Closes #465

@flodesi flodesi marked this pull request as ready for review June 22, 2020 16:35
austinabell
austinabell reviewed Jun 23, 2020
View reviewed changes
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
node/rpc/src/wallet_api.rs Outdated Show resolved Hide resolved
dutterbutter
dutterbutter approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although it would be great to see comments on the public methods.

ec2
ec2 requested changes Jun 24, 2020
View reviewed changes
Copy link
Member

@ec2 ec2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never hooked it up to the RPC at all. See node/rpc/src/lib.rs where with_method is called.

@austinabell austinabell changed the base branch from master to main June 24, 2020 15:21
@dutterbutter dutterbutter changed the title Jaden/wallet rpc wallet rpc Jun 26, 2020
ec2
ec2 requested changes Jul 7, 2020
View reviewed changes
forest/src/daemon.rs Outdated Show resolved Hide resolved
key_management/src/wallet.rs Outdated Show resolved Hide resolved
key_management/src/wallet.rs Show resolved Hide resolved
@flodesi flodesi requested a review from ec2 July 7, 2020 20:47
ec2
ec2 requested changes Jul 9, 2020
View reviewed changes
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part just a few small changes. Have you tried testing this at all by sending curl commands to some of the methods and comparing against lotus?

vm/message/src/signed_message.rs Outdated Show resolved Hide resolved
key_management/src/wallet.rs Outdated Show resolved Hide resolved
key_management/src/wallet.rs Show resolved Hide resolved
node/rpc/src/wallet_api.rs Outdated Show resolved Hide resolved
@flodesi flodesi requested a review from ec2 July 9, 2020 17:37
ec2
ec2 reviewed Jul 9, 2020
View reviewed changes
node/rpc/src/wallet_api.rs Outdated Show resolved Hide resolved
ec2
ec2 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix with the unwrap. Just as a note, we need to have a persistent keystore as a next step instead of using the memory keystore

node/rpc/src/wallet_api.rs Outdated Show resolved Hide resolved
@flodesi flodesi requested a review from austinabell July 16, 2020 14:36
@flodesi flodesi merged commit d3a1776 into main Jul 17, 2020
@flodesi flodesi deleted the jaden/wallet-rpc branch July 17, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RajarupanSampanthan RajarupanSampanthan RajarupanSampanthan left review comments

@ec2 ec2 ec2 approved these changes

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
RPC Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Wallet RPC
5 participants
@flodesi @ec2 @RajarupanSampanthan @austinabell @dutterbutter