-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CLI and implement fetch-params #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few suggestions but looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I hear reqwest is pretty heavy. It is recommended to use Surf. Surf has a lot of overlapping libs with Tide since they're built by the same people. Up to you if you think its worth the change though
Yeah thing was is that it seemed they were still on alpha for using stable futures so didn't seem worth the trial and error, I will play around with it now for a bit though |
I made a bunch of changes so just going to assume reviews invalid @AshantiMutinta @ec2 (sorry they were pretty necessary changes) |
Summary of changes
Changes introduced in this pull request:
Refactors CLI to setup framework for subcommands
forest
still runs the daemon, but subcommands can be run asforest <cmd>
such as here isforest fetch-params ..
fetch-params
command implemented which will fetch params based on the options of command and put into the params cache to be used in proof verificationThe params fetching is all done in parallel and async
Reference issue to close (if applicable)
Closes #508
Other information and links