Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update async-std runtime setup #526

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Update async-std runtime setup #526

merged 3 commits into from
Jun 30, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • The async tasks weren't being cancelled correctly in the daemon, but also changed how the main function was setup a bit

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit e0d574e into main Jun 30, 2020
@austinabell austinabell deleted the austin/runtimesetup branch June 30, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvermeulen timvermeulen timvermeulen approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@ec2 ec2 Awaiting requested review from ec2

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austinabell @timvermeulen @dutterbutter