Adding RPC Configuration #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajarupanSampanthan
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
austinabell
suggested changes
Jul 1, 2020
austinabell
reviewed
Jul 4, 2020
forest/src/daemon.rs
Outdated
| info!("Using {} as RPC port", rpc_port); | ||
| info!("Using {} as RPC listen", rpc_listen); | ||
| start_rpc(db_rpc, rpc_port, rpc_listen).await; | ||
| let rpc_listen = "127.0.0.1:".to_string() + &config.rpc_port; |
There was a problem hiding this comment.
Suggested change
| let rpc_listen = "127.0.0.1:".to_string() + &config.rpc_port; | |
| let rpc_listen = format!("127.0.0.1:{}", &config.rpc_port); |
optional: just a bit more readable
forest/src/daemon.rs
Outdated
| @@ -35,7 +35,7 @@ pub(super) async fn start(config: Config) { | |||
| }); | |||
|
|
|||
| // Initialize database | |||
| let mut db = RocksDb::new(config.data_dir + "/db"); | |||
| let mut db = RocksDb::new(config.data_dir.clone() + "/db"); | |||
There was a problem hiding this comment.
Suggested change
| let mut db = RocksDb::new(config.data_dir.clone() + "/db"); | |
| let mut db = RocksDb::new(config.data_dir + "/db"); |
nothing you added should change this, should it?
There was a problem hiding this comment.
I was doing some dumb stuff earlier, before this set up i kept running into partial move issues. I thought my only way out of it was to clone stuff, should've changed this back when i started doing it this way.
StaticallyTypedAnxiety
approved these changes
Jul 6, 2020
austinabell
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Notable changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #474
Closes #475
Other information and links