Implements deadline tests and chain epoch update to i64 #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* error in bitfield bounded iter found
austinabell
reviewed
Jul 3, 2020
austinabell
approved these changes
Jul 3, 2020
ec2
requested changes
Jul 3, 2020
vm/actor/tests/deadline_test.rs
Outdated
| dls.due[3] = bf_seq(3 * PART_SIZE + 1, 1); | ||
| dls.due[5] = bf_seq(3 * PART_SIZE + 2, 2 * PART_SIZE); | ||
|
|
||
| compute_partitions_sector(&mut dls, PART_SIZE as u64, 1, &[4]).unwrap(); |
There was a problem hiding this comment.
wouldnt this just panic on the first one and end the test?
There was a problem hiding this comment.
yeah just assert each are an error or none (I missed the should panic)
| .add_to(5, 3) | ||
| .verify(&deadlines); | ||
|
|
||
| // fill less full deadlines first |
There was a problem hiding this comment.
in spec-actors, they have this as a seperate test case
There was a problem hiding this comment.
Does that make a difference or is it just preference?
There was a problem hiding this comment.
I mean its not a BIG deal, but they two different test cases.
|
Looks like you're also missing this test https://github.com/filecoin-project/specs-actors/blob/master/actors/builtin/miner/deadlines_test.go#L229 |
ec2
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
u64toi64OptionalEpochtypeReference issue to close (if applicable)
Closes #495
Other information and links