Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenAmount and StoragePower to BigInt #540

Merged
merged 8 commits into from
Jul 16, 2020
Merged

TokenAmount and StoragePower to BigInt #540

merged 8 commits into from
Jul 16, 2020

Conversation

RajarupanSampanthan
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Changes types of StoragePower and TokenAmount to BigInt.

Reference issue to close (if applicable)

Closes

Other information and links

austinabell
austinabell suggested changes Jul 11, 2020
View reviewed changes
blockchain/chain/src/store/chain_store.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/miner/policy.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/power/policy.rs Outdated Show resolved Hide resolved
austinabell
austinabell approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, definitely are some other things affected that could be changed, but can just change when we match 1:1 for interop

@austinabell austinabell merged commit 6c30ffe into main Jul 16, 2020
@austinabell austinabell deleted the rupan/TA_refactor branch July 16, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RajarupanSampanthan @ec2 @austinabell