Implement Mock Runtime Syscalls #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajarupanSampanthan
requested review from
ansermino,
dutterbutter and
ec2
as code owners
austinabell
reviewed
Jul 14, 2020
vm/actor/tests/common/mod.rs
Outdated
| #[derive(Clone)] | ||
| pub struct ExpectComputeUnsealedSectorCid<'a> { | ||
| reg: RegisteredSealProof, | ||
| pieces: &'a Vec<PieceInfo>, |
There was a problem hiding this comment.
you should never need to have a reference to a vec instead of using a slice, is there a reason this is taking a reference to this where other types take owned values?
There was a problem hiding this comment.
No lol I was trying to match the argument in the function that used pieces. Completely forgot slices were a thing
◴_◶
…eUnsealedSectorCid
austinabell
approved these changes
Jul 14, 2020
dutterbutter
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #482
Other information and links