-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have BitField store ranges instead of bytes, and add benchmarks #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvermeulen
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
July 14, 2020 17:42
austinabell
approved these changes
Jul 14, 2020
ec2
approved these changes
Jul 16, 2020
iter: I, | ||
/// Stores the peeked range. `None` means that no range was peeked, and | ||
/// `Some(None)` means that `peek` was called but the iterator was empty. | ||
peeked: Option<Option<Range<usize>>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optionception 🧠 💥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change: remove the
RlePlus
struct that held RLE+ encoded data, and instead haveBitField
storeVec<Range<usize>>
directly. Specifically:Vec<Range<usize>>
and store those ranges insteadAs a result, deserializing a bit field is now about 1/3 slower, but deserializing + iterating a bit field is about 2x faster (and every subsequent iteration is much faster as well).
Furthermore, improved ergonomics: added a
Peekable
struct just likestd::iter::Peekable
, and have theUnion
/Intersection
/Difference
iterators store those instead of storing the iterators and next ranges separately.Peekable
distinguishes between not having looked at the next range and there not being a next range, so this allowed us to remove allFusedIterator
bounds.Other changes:
BitField::first
now has a custom implementation that does not allocateBitField::get
is made a lot faster by doing a binary search on the range vector