VM and Runtime updates #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
dutterbutter
approved these changes
Jul 29, 2020
ec2
approved these changes
Jul 29, 2020
| "actor {} must be an account ({}), was {}", | ||
| raw, &*ACCOUNT_ACTOR_CODE_ID, code_cid | ||
| ), | ||
| Err(format!( |
There was a problem hiding this comment.
Not sure why you moved the error creation out of here. Can a call to this method return a diff error?
There was a problem hiding this comment.
It's because in specs-actors there is no actor errors being returned here and no aborts in sub calls. The annoying part is that fatal errors are not handled because it panics internally in the runtime, but that's why I added to TODO to update it to match completely when I make a pass through that actor (wanted to keep scope as contained as possible)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
The scope of this is in between the actors (didn't change anything within actors that wasn't directly connected) and within the apply tipset messages (function was correct before but can be verified outside of these changes
Mainly there was just inconsistencies around how nil values were handled and the actor error handling within actors and the runtime. Huge pain to match the go implementation panicing in certain spots and catching the actor error, but I think I should have all those errors and exit codes matched (#345 but will wait to close after actor updates are done)
Reference issue to close (if applicable)
Closes #554
Other information and links