Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #51 - Add basic makefile #57

Merged
merged 7 commits into from
Dec 3, 2019
Merged

Closes #51 - Add basic makefile #57

merged 7 commits into from
Dec 3, 2019

Conversation

GregTheGreek
Copy link
Member

@GregTheGreek GregTheGreek commented Dec 3, 2019

New Features:

  • make lint
  • make build
  • make release

Notes:

  • When a new package is made you'll need to add it to the make file to be cleaned, alternatively a loop could be created.
  • Opted away from make run because that would mean passing in cli args to a Makefile which breaks the Makefile pattern

@ec2
Copy link
Member

ec2 commented Dec 3, 2019

Have you taken a look at cargo-make? https://github.com/sagiegurari/cargo-make

Makefile Outdated Show resolved Hide resolved
@GregTheGreek
Copy link
Member Author

Have you taken a look at cargo-make? https://github.com/sagiegurari/cargo-make

yeah it looks like a terrible UX ...
cargo make --makefile simple-example.toml my-flow

Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add commands to do release and standard builds (could also add subcommands for each system binary we have and make build just builds all)?

A make clean command would be nice as well as well as a run function (to either run the built binary or just to run with cargo run -p node, thoughts?

Makefile Outdated Show resolved Hide resolved
Copy link
Member

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense for clean to be a separate command. If I run make build I would not expect it to also do a clean. Maybe that's just me.

Might also be worth adding make test.

@austinabell
Copy link
Contributor

and if you make those other tweaks, might be worth to just quickly update the README

README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
GregTheGreek and others added 2 commits December 3, 2019 12:42
Co-Authored-By: Austin Abell <austinabell8@gmail.com>
@GregTheGreek GregTheGreek merged commit acb00bb into master Dec 3, 2019
@GregTheGreek GregTheGreek deleted the greg/makefile branch December 3, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants