Add Drand Beacon Cache #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snaumov
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
|
|
snaumov
force-pushed
the
snaumov/drand-bls-cache
branch
2 times, most recently
from
81bddd5
to
661b4fd
Compare
snaumov
force-pushed
the
snaumov/drand-bls-cache
branch
from
661b4fd
to
6777cda
Compare
austinabell
reviewed
Jul 29, 2020
There was a problem hiding this comment.
Few small things, definitely should get @ec2 to check this over to make sure this was what he had in mind :) Thanks so much for this PR!
austinabell
approved these changes
Jul 30, 2020
ec2
approved these changes
Jul 30, 2020
|
Let us know if you are done with changes and we can update your branch to latest main, or if you would like to do that yourself please do! (Don't want to merge main into this if you are planning on changing anything) Edit: nvm Erlich is a step ahead of this hahaha |
|
LGTM. Just merged main in. Gunna merge into main after CI is done running. This is related to my PR too, so just wanna get it in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Added
local_cachetoDrandstruct to store previously computed beacons.Reference issue to close (if applicable)
Closes #411
Other information and links