Implements Address cbor encoding #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
austinabell
commented
Dec 3, 2019
austinabell
commented
- Progress toward Setup and investigate consistent cbor encoding/decoding #35 (or can complete and create new issue with more detailed information)
- Implements address cbor encoding and tests against intermediate vectors pulled from logging the go implementation
- Fixes the leb128 encoding for ID protocols (was storing unnecessary bytes since it was storing the whole buffer as bytes which affected the cbor encoding)
austinabell
requested review from
ansermino,
dutterbutter,
ec2 and
GregTheGreek
ansermino
reviewed
Dec 3, 2019
vm/address/src/lib.rs
Outdated
| @@ -123,14 +125,14 @@ impl Address { | |||
|
|
|||
| /// Generates new address using ID protocol | |||
| pub fn new_id(id: u64) -> Result<Self, Error> { | |||
| let mut buf = [0; 1023]; | |||
| let mut buf = [0; 1024]; | |||
There was a problem hiding this comment.
Buffer size should probably be a constant
dutterbutter
approved these changes
Dec 3, 2019
ec2
approved these changes
Dec 3, 2019
|
made small tweak @ec2 @dutterbutter |
ec2
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.