Market actor update #593
Merged
Market actor update #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
ec2
reviewed
Aug 5, 2020
ec2
approved these changes
Aug 5, 2020
dutterbutter
approved these changes
Aug 6, 2020
| actor_error!(ErrIllegalState; | ||
| "failed to get deal_id ({}): {}", deal_id, e) | ||
| })? | ||
| .ok_or_else(|| actor_error!(ErrNotFound; "no such deal_id: {}", deal_id))?; |
There was a problem hiding this comment.
I don't see them using the ErrNotFound actor error here. Understandably we need to handle this error but should it be an actor error?
There was a problem hiding this comment.
yeah this ones a bit harder to trace, it's within the getDealProposal function, the !found check. It was counterproductive to add that function and check a downcasted Box<dyn StdError> outside of it. (if this is still confusing I can explain in more detail)
| .map_err( | ||
| |e| actor_error!(ErrIllegalState; "failed to get deal_id ({}): {}", deal_id, e), | ||
| )? | ||
| .ok_or_else(|| actor_error!(ErrNotFound; "proposal doesn't exist ({})", deal_id))?; |
There was a problem hiding this comment.
Similar question here as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
The changes overlapping with the miner and power actor refactors I tried to leave out of this PR, so those actors will be pretty broken until I get around to them
Also all of the market tests broke with the protocol changes and there is now 3000 lines of code in the tests so I'm not doing in this PR
Reference issue to close (if applicable)
Closes #558
Other information and links