Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address bugfix tests and bump crate version #598

Merged
merged 3 commits into from
Aug 6, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Indexing certain multi byte characters was causing a potential panic and attack vector

Reference issue to close (if applicable)

Closes #595

Other information and links

@austinabell austinabell changed the title Fix bug in non-ascii Address from string Add address bugfix tests and bump crate version Aug 4, 2020
fn invalid_strings_tests() {
let invalid_strings = &[
"fömk3zcefvlgpay4f32c5vmruk5gqig6dumc7pz6q",
"🗻∈🌏ömk3zcefvlgpay4f32c5vmruk5gqig6dumc7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌏

@austinabell austinabell merged commit 44c1cd9 into main Aug 6, 2020
@austinabell austinabell deleted the austin/address/bugfix branch August 6, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for non-utf-8 characters when converting Addresses from string slices
3 participants