Paych actor updates #608
Merged
Paych actor updates #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
dutterbutter
approved these changes
Aug 7, 2020
ec2
approved these changes
Aug 7, 2020
vm/actor/src/builtin/paych/mod.rs
Outdated
| @@ -224,18 +223,14 @@ impl Actor { | |||
| // 4. check operation validity | |||
| let new_send_balance = st.to_send.clone() + balance_delta; | |||
There was a problem hiding this comment.
could you change this to taking references instead of cloning?
There was a problem hiding this comment.
ah, ya, glossed over that one, assumed way it was setup was necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
I fixed the tests for this one (because functionality was close, but a lot of test cases were broken)
Reference issue to close (if applicable)
Closes #561
Other information and links