Rpc state implementation #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainsafe/forest into ashanti/state_api_rpc_methods
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
…fe/forest into rpc_state_implementation
ec2
reviewed
Aug 12, 2020
| pub tipset: TipsetJson, | ||
| } | ||
|
|
||
| #[derive(Serialize, Deserialize)] |
There was a problem hiding this comment.
Have you checked these against lotus? Most of their JSON keys are PascalCased
There was a problem hiding this comment.
Wasn't aware, will double check now
austinabell
reviewed
Aug 13, 2020
austinabell
added
RPC
Status: Needs Review
Status: Needs Changes
and removed
Status: Needs Review
labels
Co-authored-by: Austin Abell <austinabell8@gmail.com>
…fe/forest into rpc_state_implementation
austinabell
reviewed
Aug 17, 2020
austinabell
reviewed
Aug 17, 2020
austinabell
reviewed
Aug 17, 2020
ec2
approved these changes
Aug 18, 2020
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
austinabell
approved these changes
Aug 19, 2020
| pub msg_rct: Option<MessageReceipt>, | ||
| pub actor_error: Option<String>, | ||
| pub error: Option<String>, |
There was a problem hiding this comment.
You didn't have to change this one, but doesn't matter
There was a problem hiding this comment.
Made sense if wanted to be consistent with lotus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
-Introduced Bitfield and Address Serialization
Reference issue to close (if applicable)
Closes #528
Other information and links