Fix makefile clean and phony targets

[austinabell]

Sorry I forgot to comment on the PR that the encoding package was missing, so I added it and also included phony target definitions (makefile uses file system over definitions in file, so defines that the commands are referencing the other targets and not a file target) and a test command while I was here

[GregTheGreek]

LGTM

side note:
I dont ever see us having clean, clean-all or lint dir in our root, but probably safer than sorry

[austinabell]

LGTM

side note:
I dont ever see us having clean, clean-all or lint dir in our root, but probably safer than sorry

well, you would have to clean and recompile to check for linting issues, since warnings will only show when it is compiled. So if something compiles with a warning and that part of the code is not changed, it will not show the warning again until cleaning the built packages from the codebase. This is why it is cleaned before linting.

Wouldn't make sense to build or run inside each directory individually since it would create copies of built code from the crate and dependencies in each directory. This is the benefit to being able to run everything from root

[austinabell]

added other missing packages since review @GregTheGreek @dutterbutter

[GregTheGreek]

LGTM
side note:
I dont ever see us having clean, clean-all or lint dir in our root, but probably safer than sorry

well, you would have to clean and recompile to check for linting issues, since warnings will only show when it is compiled. So if something compiles with a warning and that part of the code is not changed, it will not show the warning again until cleaning the built packages from the codebase. This is why it is cleaned before linting.

Wouldn't make sense to build or run inside each directory individually since it would create copies of built code from the crate and dependencies in each directory. This is the benefit to being able to run everything from root

Sorry, I was referencing including the above make commands in the .PHONE