Update to new empty amt serialization #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
dutterbutter
approved these changes
Aug 14, 2020
austinabell
requested review from
StaticallyTypedAnxiety,
flodesi and
RajarupanSampanthan
ec2
reviewed
Aug 18, 2020
| @@ -49,7 +50,9 @@ pub mod json { | |||
| where | |||
| D: Deserializer<'de>, | |||
| { | |||
| let s: String = Deserialize::deserialize(deserializer)?; | |||
| Ok(VRFProof::new(base64::decode(s).map_err(de::Error::custom)?)) | |||
| let s: Cow<'de, str> = Deserialize::deserialize(deserializer)?; | |||
| @@ -51,5 +51,5 @@ where | |||
| )); | |||
| } | |||
| }; | |||
| Ok(BigInt::from_bytes_be(sign, &bz)) | |||
| Ok(BigInt::from_bytes_be(sign, &bz[1..])) | |||
There was a problem hiding this comment.
What happens if there's only a sign byte? This will panic i think, but what is the expected behaviour? I would assume 0 or something, since empty bytes -> bigint deserializes to 0?
There was a problem hiding this comment.
on the 0 case, it is serialized as empty bytes, even if it was a sign byte and nothing else, this would just deserialize as zero. Also the functionality is basically the same as it was before.
| return Err(serde::de::Error::custom( | ||
| "First byte must be 0 to decode as BigUint", | ||
| )); | ||
| } | ||
|
|
||
| Ok(BigUint::from_bytes_be(&bz)) | ||
| Ok(BigUint::from_bytes_be(&bz[1..])) |
There was a problem hiding this comment.
empty bytes get serialized as 0 and this would still not have an issue (but again Lotus and our client would not ever serialize as this case)
ec2
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links