Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in reading and persisting keystore data #625

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • After Add Persistent KeyStore #604 file was created on initializing a keystore, but was never written. When the file was attempted to be read, if the bytes were invalid, the node would error before starting.
    • I was going to make the file read recoverable, but in the case of a file not being fully written and has keys that are wanted, figured overwriting shouldn't be assumed

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell force-pushed the austin/keystore branch 2 times, most recently from 2526a2c to 556e39a Compare August 13, 2020 22:01
@austinabell austinabell merged commit 8192c12 into main Aug 14, 2020
@austinabell austinabell deleted the austin/keystore branch August 14, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants