Adding Puppet Actor #627
Merged
Adding Puppet Actor #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajarupanSampanthan
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
austinabell
reviewed
Aug 13, 2020
ec2
approved these changes
Aug 18, 2020
austinabell
reviewed
Aug 19, 2020
austinabell
suggested changes
Aug 19, 2020
vm/actor/src/builtin/puppet/mod.rs
Outdated
| rt.validate_immediate_caller_accept_any()?; | ||
|
|
||
| rt.transaction(|st: &mut State, _| { | ||
| st.opt_fail = vec![]; |
There was a problem hiding this comment.
I don't think this fails in our case (and hope this doesn't ever get hit in our node outside of this, but I don't see why theirs would fail if that type never gets serialized) You might want to write a test or something to check if serializing an empty vec of FailToMarshalCBOR will error
There was a problem hiding this comment.
Just wrote the test and a empty vec of FailToMarshalCBOR can be successfully serialized, atleast the way I have it right now. It only fails if the vector actually has something it.
austinabell
reviewed
Aug 19, 2020
Comment on lines
+79
to
+88
| fn serialize_test() { | ||
| let mut v: Vec<FailToMarshalCBOR> = vec![]; | ||
|
|
||
| // Should pass becuase vec is empty | ||
| assert!(Serialized::serialize(&v).is_ok()); | ||
|
|
||
| v.push(FailToMarshalCBOR::default()); | ||
|
|
||
| // Should fail becuase vec is no longer empty | ||
| assert!(Serialized::serialize(v).is_err()); |
There was a problem hiding this comment.
Can you also check the case for runtime_transaction_marshal_cbor_failure? my intuition is that it won't error as it's expected to
austinabell
reviewed
Aug 20, 2020
austinabell
reviewed
Aug 24, 2020
austinabell
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #566
Other information and links