Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test runner #638

Merged
merged 25 commits into from
Aug 25, 2020
Merged

Conformance test runner #638

merged 25 commits into from
Aug 25, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

Currently blocked on:

Reference issue to close (if applicable)

Closes #637

Other information and links

@austinabell austinabell marked this pull request as draft August 19, 2020 18:45
@austinabell austinabell added Status: BLOCKED VM Interop Interop with Lotus/specs-actors and testing labels Aug 19, 2020
@ec2
Copy link
Member

ec2 commented Aug 24, 2020

This shouldnt be blocked anymore, right?

@austinabell
Copy link
Contributor Author

This shouldnt be blocked anymore, right?

I'm making changes now and testing to see how many I can get passing, but will open up soon (also want to update to most recent test-vectors commit)

@austinabell austinabell marked this pull request as ready for review August 24, 2020 18:22
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One thing that we will want is the ability to run tests selectively in the case of specific test case failures, but we can add that in later.

@@ -49,16 +49,13 @@ pub trait Store {
}

/// Write slice of KV pairs.
fn bulk_write<K, V>(&self, keys: &[K], values: &[V]) -> Result<(), Error>
fn bulk_write<K, V>(&self, values: &[(K, V)]) -> Result<(), Error>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This actually makes a lot more sense.

@austinabell
Copy link
Contributor Author

Looks good! One thing that we will want is the ability to run tests selectively in the case of specific test case failures, but we can add that in later.

How do you expect this to happen? The test cases are based on the submodule json files so I don't see how you do this with rust's test framework. Are you suggesting an env variable with some regex for tests to run? The regex skipping system is a bit clunky because the test file has to be recompiled, but I don't see the problem with using it the way it is to do this

@austinabell austinabell merged commit 3e6c2ee into main Aug 25, 2020
@austinabell austinabell deleted the austin/tvframework branch August 25, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interop Interop with Lotus/specs-actors and testing Status: BLOCKED VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants