Dynamic Gas Implementation #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
timvermeulen,
RajarupanSampanthan,
flodesi and
StaticallyTypedAnxiety
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
| { | ||
| let mut total_limit = 0; | ||
| for b in ts.blocks() { | ||
| let (msg1, msg2) = crate::block_messages(db, &b)?; |
There was a problem hiding this comment.
it would be nice to have a function like block_messages which returns ChainMessage because this is one of the cases where we don't care if it is a signed or unsigned message that is returned. We are just worrying about the gas_limit on that particular message.
Edit : This is not necessary to change btw. Was just a comment in passing
austinabell
reviewed
Aug 19, 2020
austinabell
suggested changes
Aug 20, 2020
StaticallyTypedAnxiety
approved these changes
Aug 21, 2020
austinabell
reviewed
Aug 21, 2020
austinabell
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
TODO: Fix broken existing tests including the message serializations
Reference issue to close (if applicable)
Closes
Other information and links