-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Mdns and Kad Toggle #647
Conversation
…le version that has the needed Toggle functions
Adding main
I'm confused by the tags haha. It's currently do not merge? Is there a reason you didnt open a draft PR? Or did you mislabel accidentally? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, but can you also add a flag to the forest binary so you can configure bootstrap config without requiring a config file. (Lotus has a flag --bootstrap
that defaults to true and can disable kad, but I see the benefit in having both --kademlia/--bootstrap and --mdns flags that default to true)
Open to suggestions on the usage of this though, just sharing thoughts
I was debating whether to hold off on submitting this because our daemon doesnt start up so actual testing might've been difficult, which is why I added those tags. Wasn't sure what the best tag was for it lol. Logically though its pretty simple and makes sense which is why I ended up submitting it anyway |
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Summary of changes
Changes introduced in this pull request:
Sample Config File :
data_dir = "test_dir"
[network]
listening_multiaddr = "/ip4/0.0.0.0/tcp/40000"
bootstrap_peers = ["/ip4/54.186.82.90/tcp/1347"]
mdns = false
kademlia = false
Reference issue to close (if applicable)
Closes
#502
Other information and links